linux-kernel - Re: [PATCH] kselftest/cgroup: fix test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f819f288-7f67-77d1-5d92-f0a5545c1c48@redhat.com>
Date:   Fri, 13 May 2022 12:19:24 -0400
From:   Waiman Long <longman@...hat.com>
To:     Phil Auld <pauld@...hat.com>, linux-kernel@...r.kernel.org
Cc:     mkoutny@...e.com, tj@...nel.org
Subject: Re: [PATCH] kselftest/cgroup: fix test_stress.sh to use OUTPUT dir


On 5/12/22 10:34, Phil Auld wrote:
> Running cgroup kselftest with O= fails to run the with_stress test due
> to hardcoded ./test_core. Find test_core binary using the OUTPUT directory.
>
> Fixes: 1a99fcc035fb ("selftests: cgroup: Run test_core under interfering stress")
> Signed-off-by: Phil Auld <pauld@...hat.com>
> ---
>   tools/testing/selftests/cgroup/test_stress.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_stress.sh b/tools/testing/selftests/cgroup/test_stress.sh
> index 15d9d5896394..109c044f715f 100755
> --- a/tools/testing/selftests/cgroup/test_stress.sh
> +++ b/tools/testing/selftests/cgroup/test_stress.sh
> @@ -1,4 +1,4 @@
>   #!/bin/bash
>   # SPDX-License-Identifier: GPL-2.0
>   
> -./with_stress.sh -s subsys -s fork ./test_core
> +./with_stress.sh -s subsys -s fork ${OUTPUT}/test_core


I would suggest using "${OUTPUT:-.}" as the variable OUTPUT may not be 
defined if test_stress.sh is run interactively.

Cheers,
Longman