linux-kernel - Re: [PATCH -next] ARM: davinci: da850-evm: add missing platform_device_unregister in da850_lcd_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 14 May 2022 14:39:33 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Zheng Bin <zhengbin13@...wei.com>
Cc:     Sekhar Nori <nsekhar@...com>, Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        gaochao49@...wei.com
Subject: Re: [PATCH -next] ARM: davinci: da850-evm: add missing
 platform_device_unregister in da850_lcd_hw_init

On Wed, May 11, 2022 at 10:51 AM Zheng Bin <zhengbin13@...wei.com> wrote:
>
> da850_lcd_hw_init misses a call platform_device_unregister in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---
>  arch/arm/mach-davinci/board-da850-evm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index efc26b472ef8..7b2a1a37e5c0 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
> @@ -873,8 +873,10 @@ static int da850_lcd_hw_init(void)
>                 return PTR_ERR(backlight);
>
>         status = platform_device_register(&da850_lcd_supply_device);
> -       if (status)
> +       if (status) {
> +               platform_device_unregister(backlight);
>                 return status;
> +       }
>
>         return 0;
>  }
> --
> 2.31.1
>

Reviewed-by: Bartosz Golaszewski <brgl@...ev.pl>