linux-kernel - Re: [RFC v2 12/39] i2c: add HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yn+3cZ02UDP19XGu@shikoro>
Date:   Sat, 14 May 2022 16:06:41 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Niklas Schnelle <schnelle@...ux.ibm.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-pci@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>,
        "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>
Subject: Re: [RFC v2 12/39] i2c: add HAS_IOPORT dependencies

On Fri, Apr 29, 2022 at 03:50:19PM +0200, Niklas Schnelle wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
> 
> Co-developed-by: Arnd Bergmann <arnd@...nel.org>
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>

What has changed since RFC v1?

> @@ -1232,6 +1233,7 @@ config I2C_CP2615
>  config I2C_PARPORT
>  	tristate "Parallel port adapter"
>  	depends on PARPORT
> +	depends on HAS_IOPORT
>  	select I2C_ALGOBIT
>  	select I2C_SMBUS
>  	help

Didn't you want to drop this one?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)