linux-kernel - Re: [RFC PATCH v2 2/2] kbuild: call check-atomics.sh only if prerequisites change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAR+F5PspM+6CP+H+443nJYy+Rg3jmKp1NyJeepq9sSFQA@mail.gmail.com>
Date:   Sun, 15 May 2022 01:26:23 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Will Deacon <will@...nel.org>
Subject: Re: [RFC PATCH v2 2/2] kbuild: call check-atomics.sh only if
 prerequisites change

On Sat, May 14, 2022 at 11:56 PM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Sat, May 14, 2022 at 03:14:48PM +0200, Peter Zijlstra wrote:
> > On Sat, May 14, 2022 at 04:01:18AM +0900, Masahiro Yamada wrote:
> > > I wrote a different patch.
> > > https://lore.kernel.org/lkml/20220513185340.239753-1-masahiroy@kernel.org/T/#u
> >
> > I'm not seeing that in my inbox :-(
> >
> > AFAICT this way 'make tags' will not find and index the files, which is
> > a total no-go.
> >
> > NAK
>
> Additionally, if you spuriously regenerate these files, you'll risk
> rebuilding huge parts of the kernel through the dependencies.

This is just one-time copying.
Rebuild only happens just once.


BTW, gen-atomics.sh takes more than 1 sec.
Do you think gen-atomics.sh can be much faster
if it is rewritten by Python or Perl?
Then, we can drop 5000 lines from the git repository.



-- 
Best Regards
Masahiro Yamada