linux-kernel - Re: [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30e805ba-cf4d-c13c-8d34-e1b2d9e77dae@linux.alibaba.com>
Date:   Sat, 14 May 2022 09:42:06 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        catalin.marinas@....com, will@...nel.org
Cc:     mike.kravetz@...cle.com, akpm@...ux-foundation.org,
        songmuchun@...edance.com, willy@...radead.org,
        christophe.leroy@...roup.eu, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value
 of a huge page



On 5/13/2022 6:50 PM, Anshuman Khandual wrote:
> 
> 
> On 5/13/22 09:07, Baolin Wang wrote:
>> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(),
> 
> Right, as arm64 does not enable __HAVE_ARCH_HUGE_PTEP_GET.
> 
>> which will not take into account any contig-PTEs dirty and access bits.
> 
> As expected being operating on a single table entry.
> 
>> Meanwhile we will implement a new ARM64-specific huge_ptep_get()
>> interface in following patch, which will take into account any contig-PTEs
>> dirty and access bits. To keep the same efficient logics to get the pte
> 
> s/logics/logic

Will fix.

> 
>> value, change to use ptep_get() as a preparation.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
>> Reviewed-by: Muchun Song <songmuchun@...edance.com>
> 
> LGTM
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

Thanks.