lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 May 2022 11:40:00 +0100 From: Marc Zyngier <maz@...nel.org> To: Paolo Bonzini <pbonzini@...hat.com> Cc: Oliver Upton <oupton@...gle.com>, Raghavendra Rao Ananta <rananta@...gle.com>, Andrew Jones <drjones@...hat.com>, James Morse <james.morse@....com>, Alexandru Elisei <alexandru.elisei@....com>, Suzuki K Poulose <suzuki.poulose@....com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Peter Shier <pshier@...gle.com>, Ricardo Koller <ricarkol@...gle.com>, Reiji Watanabe <reijiw@...gle.com>, Jing Zhang <jingzhangos@...gle.com>, linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu, linux-kernel@...r.kernel.org, kvm@...r.kernel.org, linux-kselftest@...r.kernel.org Subject: Re: [PATCH] selftests: KVM: aarch64: Let hypercalls use UAPI *_BIT_COUNT On 2022-05-05 14:32, Paolo Bonzini wrote: > On 5/5/22 14:04, Marc Zyngier wrote: >> diff --git a/arch/arm64/include/uapi/asm/kvm.h >> b/arch/arm64/include/uapi/asm/kvm.h >> index e523bb6eac67..3cde9f958eee 100644 >> --- a/arch/arm64/include/uapi/asm/kvm.h >> +++ b/arch/arm64/include/uapi/asm/kvm.h >> @@ -342,6 +342,10 @@ struct kvm_arm_copy_mte_tags { >> enum { >> KVM_REG_ARM_STD_BIT_TRNG_V1_0 = 0, >> + /* >> + * KVM_REG_ARM_STD_BMAP_BIT_COUNT will vary as new services >> + * are added, and is explicitely not part of the ABI. >> + */ >> KVM_REG_ARM_STD_BMAP_BIT_COUNT, >> }; > > That seems like a bad idea. Perhaps you can wrap it in #ifdef > __KERNEL_OR_SELFTESTS__? I can't find any prior art. Yeah. I've dropped this patch and sprinkled a bunch of '#ifdef __KERNEL__' instead. We can revisit this later, or hack the test to temporarily define __KERNEL__, which is just as bad... M. -- Jazz is not dead. It just smells funny...
Powered by blists - more mailing lists