linux-kernel - Re: [x86/uaccess] 9c5743dff4: WARNING:at_arch/x86/mm/extable.c:#ex_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pmkerglk.ffs@tglx>
Date:   Sun, 15 May 2022 16:54:47 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        kernel test robot <oliver.sang@...el.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        kernel test robot <lkp@...el.com>,
        the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [x86/uaccess] 9c5743dff4:
 WARNING:at_arch/x86/mm/extable.c:#ex_handler_fprestore

On Sun, May 15 2022 at 10:25, Thomas Gleixner wrote:
> On Fri, May 13 2022 at 09:52, Linus Torvalds wrote:
> The code which copies the ptrace supplied state has a pile of sanity
> checks to catch invalid state, but I wouldn't bet my hat on it that it's
> 100% complete. We can be more defensive here, but I would be surprised.
>
> Something like the untested below. I'll expose it to some testing to see
> what explodes.

I was not able to get something broken past the existing sanity checks
which was caught by the trial restore. I seems the FPU units are pretty
resilent against random nonsense except for the XSTATE header and the
MXCRS content. Though I ponder to just add that trial restore due to
paranoia.

Thanks,

        tglx