linux-kernel - Re: [PATCH 4/5] audit: remove redundant data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 May 2022 19:30:11 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Shreenidhi Shedi <yesshedi@...il.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org, eparis@...hat.com,
        linux-kernel@...r.kernel.org, linux-audit@...hat.com,
        Shreenidhi Shedi <sshedi@...are.com>
Subject: Re: [PATCH 4/5] audit: remove redundant data_len check

On Sat, May 14, 2022 at 5:15 PM Shreenidhi Shedi <yesshedi@...il.com> wrote:
>
> Signed-off-by: Shreenidhi Shedi <sshedi@...are.com>
> ---
>  kernel/audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

As a FYI for the non-audit folks on the To/CC line, patches 4/5 and
5/5 were resent to just the audit relevant folks so I'll follow-up
there.

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7690c29d4ee4..0749211d5552 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1390,7 +1390,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>                                                  str);
>                         } else {
>                                 audit_log_format(ab, " data=");
> -                               if (data_len > 0 && str[data_len - 1] == '\0')
> +                               if (str[data_len - 1] == '\0')
>                                         data_len--;
>                                 audit_log_n_untrustedstring(ab, str, data_len);
>                         }
> --
> 2.36.1

-- 
paul-moore.com