linux-kernel - Re: [PATCH 2/2] audit: fix most of the checkpatch.pl warnnings & errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhRPTV2sDdGgczLAN7dW+kkX06=1=Qas4QGztXtricBjag@mail.gmail.com>
Date:   Sun, 15 May 2022 19:44:23 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Shreenidhi Shedi <yesshedi@...il.com>
Cc:     eparis@...hat.com, linux-kernel@...r.kernel.org,
        linux-audit@...hat.com, Shreenidhi Shedi <sshedi@...are.com>
Subject: Re: [PATCH 2/2] audit: fix most of the checkpatch.pl warnnings & errors

On Sun, May 15, 2022 at 3:31 AM Shreenidhi Shedi <yesshedi@...il.com> wrote:
>
> This commit fixes almost all styling issues reported by checkpatch.pl
> script.
>
> Signed-off-by: Shreenidhi Shedi <sshedi@...are.com>
> ---
>  kernel/audit.c | 205 ++++++++++++++++++++++++++++++-------------------
>  1 file changed, 127 insertions(+), 78 deletions(-)

Please don't send me patches like this unless you are an established
contributor to the audit subsystem, and even then I would strongly
encourage you to think long and hard before hitting send.

Most of this patch is just comment formatting churn, which is okay if
you are doing something else in a nearby section of code, but a +200
line patch of such changes is not okay.  The printk ratelimiting
changes are probably okay to submit in a separate patch, but I didn't
look at all of them.  Although some of the pr_cont() to pr_info()
conversions warrant a closer look.  The EXPORT_SYMBOL() relocations
are probably also okay is sent as a separate patch.

-- 
paul-moore.com