linux-kernel - Re: [PATCH V2] dmaengine: idxd: Remove unnecessary synchronize_irq() before free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoKO5RFQVsgGSwqE@matsya>
Date:   Mon, 16 May 2022 23:20:29 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     cgel.zte@...il.com
Cc:     chi.minghao@....com.cn, dave.jiang@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        zealci@....com.cn
Subject: Re: [PATCH V2] dmaengine: idxd: Remove unnecessary synchronize_irq()
 before free_irq()

On 16-05-22, 11:54, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.

You should not have missed Dave's ack. I have added that and pushed

-- 
~Vinod