linux-kernel - Re: [PATCH] scripts:modify output format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aeee9a4-e8e1-bcac-1ebb-f2b8860ba363@infradead.org>
Date:   Sun, 15 May 2022 22:19:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dong Chuanjian <chuanjian@...china.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Changbin Du <changbin.du@...el.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     linux-kernel@...r.kernel.org, Kernel@...china.com
Subject: Re: [PATCH] scripts:modify output format

Hi,

The change looks good to me, but there are a few other
"process" problems.

1. Was there a compiler warning that caused this patch?
If so, then tell us about it.

2. This is v2 of the patch. You should describe what changed
between v1 and v2 (below the first --- line).

Thanks.

On 5/15/22 19:04, Dong Chuanjian wrote:
> scripts:modify output format
> 
> Signed-off-by: Dong Chuanjian <chuanjian@...china.com>
> ---
>  scripts/kallsyms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 8caabddf817c..ba50993785ec 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -498,7 +498,7 @@ static void write_src(void)
>  
>  	output_label("kallsyms_token_index");
>  	for (i = 0; i < 256; i++)
> -		printf("\t.short\t%d\n", best_idx[i]);
> +		printf("\t.short\t%u\n", best_idx[i]);
>  	printf("\n");
>  }
>  

-- 
~Randy