linux-kernel - [linux-stable-rc:queue/5.10 60/64] arch/m68k/include/asm/bitops.h:61:33: warning: this statement may fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202205170258.uYXmpA7O-lkp@intel.com>
Date:   Tue, 17 May 2022 02:28:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Trond Myklebust <trond.myklebust@...merspace.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Sasha Levin <sashal@...nel.org>,
        Meena Shanmugam <meenashanmugam@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [linux-stable-rc:queue/5.10 60/64]
 arch/m68k/include/asm/bitops.h:61:33: warning: this statement may fall
 through

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.10
head:   678760868882a1b8dd7f45e9b6058f2c0ce109a3
commit: 419aeb75528619e8bfedecb70c70abcc72464e71 [60/64] SUNRPC: Don't call connect() more than once on a TCP socket
config: m68k-randconfig-r003-20220516 (https://download.01.org/0day-ci/archive/20220517/202205170258.uYXmpA7O-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=419aeb75528619e8bfedecb70c70abcc72464e71
        git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
        git fetch --no-tags linux-stable-rc queue/5.10
        git checkout 419aeb75528619e8bfedecb70c70abcc72464e71
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/sunrpc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/string.h:6,
                    from net/sunrpc/xprtsock.c:23:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:51: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr)  (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                   ^~
   include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
      78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/scatterlist.h:143:9: note: in expansion of macro 'BUG_ON'
     143 |         BUG_ON(!virt_addr_valid(buf));
         |         ^~~~~~
   include/linux/scatterlist.h:143:17: note: in expansion of macro 'virt_addr_valid'
     143 |         BUG_ON(!virt_addr_valid(buf));
         |                 ^~~~~~~~~~~~~~~
   In file included from include/linux/bitops.h:29,
                    from include/linux/kernel.h:12,
                    from include/asm-generic/bug.h:20,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:15,
                    from net/sunrpc/xprtsock.c:24:
   net/sunrpc/xprtsock.c: In function 'xs_tcp_setup_socket':
>> arch/m68k/include/asm/bitops.h:61:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
      61 | #define set_bit(nr, vaddr)      bset_mem_set_bit(nr, vaddr)
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/sunrpc/xprtsock.c:2301:17: note: in expansion of macro 'set_bit'
    2301 |                 set_bit(XPRT_SOCK_CONNECT_SENT, &transport->sock_state);
         |                 ^~~~~~~
   net/sunrpc/xprtsock.c:2302:9: note: here
    2302 |         case -EALREADY:
         |         ^~~~


vim +61 arch/m68k/include/asm/bitops.h

171d809df1896c1 Greg Ungerer 2011-05-17  57  
171d809df1896c1 Greg Ungerer 2011-05-17  58  #if defined(CONFIG_COLDFIRE)
171d809df1896c1 Greg Ungerer 2011-05-17  59  #define	set_bit(nr, vaddr)	bset_reg_set_bit(nr, vaddr)
171d809df1896c1 Greg Ungerer 2011-05-17  60  #elif defined(CONFIG_CPU_HAS_NO_BITFIELDS)
171d809df1896c1 Greg Ungerer 2011-05-17 @61  #define	set_bit(nr, vaddr)	bset_mem_set_bit(nr, vaddr)
171d809df1896c1 Greg Ungerer 2011-05-17  62  #else
171d809df1896c1 Greg Ungerer 2011-05-17  63  #define set_bit(nr, vaddr)	(__builtin_constant_p(nr) ? \
171d809df1896c1 Greg Ungerer 2011-05-17  64  				bset_mem_set_bit(nr, vaddr) : \
171d809df1896c1 Greg Ungerer 2011-05-17  65  				bfset_mem_set_bit(nr, vaddr))
171d809df1896c1 Greg Ungerer 2011-05-17  66  #endif
171d809df1896c1 Greg Ungerer 2011-05-17  67  

:::::: The code at line 61 was first introduced by commit
:::::: 171d809df1896c1022f9778cd2788be6c255a7dc m68k: merge mmu and non-mmu bitops.h

:::::: TO: Greg Ungerer <gerg@...inux.org>
:::::: CC: Greg Ungerer <gerg@...inux.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp