linux-kernel - [linux-stable-rc:queue/5.10 60/64] arch/arm/include/asm/bitops.h:183:41: warning: this statement may fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 02:39:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Trond Myklebust <trond.myklebust@...merspace.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Sasha Levin <sashal@...nel.org>,
        Meena Shanmugam <meenashanmugam@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [linux-stable-rc:queue/5.10 60/64]
 arch/arm/include/asm/bitops.h:183:41: warning: this statement may fall
 through

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.10
head:   678760868882a1b8dd7f45e9b6058f2c0ce109a3
commit: 419aeb75528619e8bfedecb70c70abcc72464e71 [60/64] SUNRPC: Don't call connect() more than once on a TCP socket
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20220517/202205170208.3xcnwB0O-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=419aeb75528619e8bfedecb70c70abcc72464e71
        git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
        git fetch --no-tags linux-stable-rc queue/5.10
        git checkout 419aeb75528619e8bfedecb70c70abcc72464e71
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/sunrpc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/bitops.h:29,
                    from include/linux/kernel.h:12,
                    from include/asm-generic/bug.h:20,
                    from arch/arm/include/asm/bug.h:60,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:15,
                    from net/sunrpc/xprtsock.c:24:
   net/sunrpc/xprtsock.c: In function 'xs_tcp_setup_socket':
>> arch/arm/include/asm/bitops.h:183:41: warning: this statement may fall through [-Wimplicit-fallthrough=]
     183 | #define ATOMIC_BITOP(name,nr,p)         _##name(nr,p)
         |                                         ^~~~~~~~~~~~~
   arch/arm/include/asm/bitops.h:189:41: note: in expansion of macro 'ATOMIC_BITOP'
     189 | #define set_bit(nr,p)                   ATOMIC_BITOP(set_bit,nr,p)
         |                                         ^~~~~~~~~~~~
   net/sunrpc/xprtsock.c:2301:17: note: in expansion of macro 'set_bit'
    2301 |                 set_bit(XPRT_SOCK_CONNECT_SENT, &transport->sock_state);
         |                 ^~~~~~~
   net/sunrpc/xprtsock.c:2302:9: note: here
    2302 |         case -EALREADY:
         |         ^~~~


vim +183 arch/arm/include/asm/bitops.h

^1da177e4c3f415 include/asm-arm/bitops.h      Linus Torvalds 2005-04-16  175  
e7ec02938dbe8ca include/asm-arm/bitops.h      Russell King   2005-07-28  176  #ifndef CONFIG_SMP
^1da177e4c3f415 include/asm-arm/bitops.h      Linus Torvalds 2005-04-16  177  /*
^1da177e4c3f415 include/asm-arm/bitops.h      Linus Torvalds 2005-04-16  178   * The __* form of bitops are non-atomic and may be reordered.
^1da177e4c3f415 include/asm-arm/bitops.h      Linus Torvalds 2005-04-16  179   */
6323f0ccedf756d arch/arm/include/asm/bitops.h Russell King   2011-01-16  180  #define ATOMIC_BITOP(name,nr,p)			\
6323f0ccedf756d arch/arm/include/asm/bitops.h Russell King   2011-01-16  181  	(__builtin_constant_p(nr) ? ____atomic_##name(nr, p) : _##name(nr,p))
e7ec02938dbe8ca include/asm-arm/bitops.h      Russell King   2005-07-28  182  #else
6323f0ccedf756d arch/arm/include/asm/bitops.h Russell King   2011-01-16 @183  #define ATOMIC_BITOP(name,nr,p)		_##name(nr,p)
e7ec02938dbe8ca include/asm-arm/bitops.h      Russell King   2005-07-28  184  #endif
^1da177e4c3f415 include/asm-arm/bitops.h      Linus Torvalds 2005-04-16  185  

:::::: The code at line 183 was first introduced by commit
:::::: 6323f0ccedf756dfe5f46549cec69a2d6d97937b ARM: bitops: switch set/clear/change bitops to use ldrex/strex

:::::: TO: Russell King <rmk+kernel@....linux.org.uk>
:::::: CC: Russell King <rmk+kernel@....linux.org.uk>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp