linux-kernel - Re: [PATCH] soc: mediatek: mtk-mmsys: Add support for MT6795 Helio X10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 May 2022 13:43:01 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, <matthias.bgg@...il.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <konrad.dybcio@...ainline.org>,
        <marijn.suijten@...ainline.org>, <martin.botka@...ainline.org>,
        <~postmarketos/upstreaming@...ts.sr.ht>,
        <phone-devel@...r.kernel.org>, <paul.bouchara@...ainline.org>,
        <kernel@...labora.com>
Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Add support for MT6795 Helio
 X10

Hi, Angelo:

On Fri, 2022-05-13 at 19:03 +0200, AngeloGioacchino Del Regno wrote:
> Add MM support for the MT6795 SoC, using the mmsys default routing
> table.
> 
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> ---
> 
> In order for this patch to have any meaning and functionality, it is
> required to also have in-tree the [1] MT6795 clocks series, even
> though that's not required to actually compile this code.
> 
> [1] 
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=641493__;!!CTRNKA9wMg0ARbw!ywDb_Gj4oV0iYHK_PbtJSNejzsJGlFVjX-1O0G1mR0vZX_5VeMtlZJ_AS6K_Mg$
>  
> 
>  drivers/soc/mediatek/mtk-mmsys.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c
> b/drivers/soc/mediatek/mtk-mmsys.c
> index 06d8e83a2cb5..38b36b881a3b 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -57,6 +57,13 @@ static const struct mtk_mmsys_match_data
> mt6779_mmsys_match_data = {
>  	},
>  };
>  
> +static const struct mtk_mmsys_driver_data mt6795_mmsys_driver_data =
> {
> +	.clk_driver = "clk-mt6795-mm",
> +	.routes = mmsys_default_routing_table,

mt6795 should have its own routing table instead of default one. The
default one is used for mt8173, mt2701, mt2712 which no one knows how
to separate them. If you don't know the routing table of mt6795, just
left this as NULL.

Regards,
CK

> +	.num_routes = ARRAY_SIZE(mmsys_default_routing_table),
> +	.sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,
> +};
> +
>  static const struct mtk_mmsys_driver_data mt6797_mmsys_driver_data =
> {
>  	.clk_driver = "clk-mt6797-mm",
>  };
> @@ -363,6 +370,10 @@ static const struct of_device_id
> of_match_mtk_mmsys[] = {
>  		.compatible = "mediatek,mt6779-mmsys",
>  		.data = &mt6779_mmsys_match_data,
>  	},
> +	{
> +		.compatible = "mediatek,mt6795-mmsys",
> +		.data = &mt6795_mmsys_driver_data,
> +	},
>  	{
>  		.compatible = "mediatek,mt6797-mmsys",
>  		.data = &mt6797_mmsys_match_data,