linux-kernel - Re: [PATCH] kselftests/ir : Improve readability of modprobe error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a763b159-0072-b883-5e47-65f86bec66dd@linuxfoundation.org>
Date:   Mon, 16 May 2022 13:48:01 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Gautam Menghani <gautammenghani201@...il.com>, shuah@...nel.org,
        linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kselftests/ir : Improve readability of modprobe error
 message

On 5/13/22 1:07 PM, Gautam Menghani wrote:
> Improve the readability of error message which says module not found.
> The new behaviour is consistent with the modprobe command.
> 
> Signed-off-by: Gautam Menghani <gautammenghani201@...il.com>
> ---
>   tools/testing/selftests/ir/ir_loopback.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh
> index b90dc9939f45..aff9299c9416 100755
> --- a/tools/testing/selftests/ir/ir_loopback.sh
> +++ b/tools/testing/selftests/ir/ir_loopback.sh
> @@ -10,7 +10,7 @@ if [ $UID != 0 ]; then
>   fi
>   
>   if ! /sbin/modprobe -q -n rc-loopback; then
> -        echo "ir_loopback: module rc-loopback is not found [SKIP]"
> +        echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]"
>           exit $ksft_skip
>   fi
>   
> 

Applied to linux-kselftest next for 5.19-rc1

thanks,
-- Shuah