lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202205170600.JCflVJO1-lkp@intel.com>
Date:   Tue, 17 May 2022 06:37:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Haiyue Wang <haiyue.wang@...el.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Tony Nguyen <anthony.l.nguyen@...el.com>
Subject: drivers/net/ethernet/intel/iavf/iavf_fdir.c:340:5: warning: format
 specifies type 'unsigned short' but the argument has type 'int'

Hi Haiyue,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   42226c989789d8da4af1de0c31070c96726d990c
commit: 527691bf0682d7ddcca77fc17dabd2fa090572ff iavf: Support IPv4 Flow Director filters
date:   1 year, 2 months ago
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220517/202205170600.JCflVJO1-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=527691bf0682d7ddcca77fc17dabd2fa090572ff
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 527691bf0682d7ddcca77fc17dabd2fa090572ff
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/ethernet/intel/iavf/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/intel/iavf/iavf_fdir.c:340:5: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                            ntohs(fltr->ip_data.dst_port),
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:118:33: note: expanded from macro 'dev_info'
           _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                  ~~~     ^~~~~~~~~~~
   include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
   #define ntohs(x) ___ntohs(x)
                    ^~~~~~~~~~~
   include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
   #define ___ntohs(x) __be16_to_cpu(x)
                       ^~~~~~~~~~~~~~~~
   include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro '__be16_to_cpu'
   #define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
           (__builtin_constant_p((__u16)(x)) ?     \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/intel/iavf/iavf_fdir.c:341:5: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                            ntohs(fltr->ip_data.src_port));
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:118:33: note: expanded from macro 'dev_info'
           _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                  ~~~     ^~~~~~~~~~~
   include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
   #define ntohs(x) ___ntohs(x)
                    ^~~~~~~~~~~
   include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
   #define ___ntohs(x) __be16_to_cpu(x)
                       ^~~~~~~~~~~~~~~~
   include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro '__be16_to_cpu'
   #define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
           (__builtin_constant_p((__u16)(x)) ?     \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +340 drivers/net/ethernet/intel/iavf/iavf_fdir.c

   316	
   317	/**
   318	 * iavf_print_fdir_fltr
   319	 * @adapter: adapter structure
   320	 * @fltr: Flow Director filter to print
   321	 *
   322	 * Print the Flow Director filter
   323	 **/
   324	void iavf_print_fdir_fltr(struct iavf_adapter *adapter, struct iavf_fdir_fltr *fltr)
   325	{
   326		const char *proto = iavf_fdir_flow_proto_name(fltr->flow_type);
   327	
   328		if (!proto)
   329			return;
   330	
   331		switch (fltr->flow_type) {
   332		case IAVF_FDIR_FLOW_IPV4_TCP:
   333		case IAVF_FDIR_FLOW_IPV4_UDP:
   334		case IAVF_FDIR_FLOW_IPV4_SCTP:
   335			dev_info(&adapter->pdev->dev, "Rule ID: %u dst_ip: %pI4 src_ip %pI4 %s: dst_port %hu src_port %hu\n",
   336				 fltr->loc,
   337				 &fltr->ip_data.v4_addrs.dst_ip,
   338				 &fltr->ip_data.v4_addrs.src_ip,
   339				 proto,
 > 340				 ntohs(fltr->ip_data.dst_port),
   341				 ntohs(fltr->ip_data.src_port));
   342			break;
   343		case IAVF_FDIR_FLOW_IPV4_AH:
   344		case IAVF_FDIR_FLOW_IPV4_ESP:
   345			dev_info(&adapter->pdev->dev, "Rule ID: %u dst_ip: %pI4 src_ip %pI4 %s: SPI %u\n",
   346				 fltr->loc,
   347				 &fltr->ip_data.v4_addrs.dst_ip,
   348				 &fltr->ip_data.v4_addrs.src_ip,
   349				 proto,
   350				 ntohl(fltr->ip_data.spi));
   351			break;
   352		case IAVF_FDIR_FLOW_IPV4_OTHER:
   353			dev_info(&adapter->pdev->dev, "Rule ID: %u dst_ip: %pI4 src_ip %pI4 proto: %u L4_bytes: 0x%x\n",
   354				 fltr->loc,
   355				 &fltr->ip_data.v4_addrs.dst_ip,
   356				 &fltr->ip_data.v4_addrs.src_ip,
   357				 fltr->ip_data.proto,
   358				 ntohl(fltr->ip_data.l4_header));
   359			break;
   360		default:
   361			break;
   362		}
   363	}
   364	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ