linux-kernel - Re: [PATCH bpf 1/4] bpf_trace: check size for overflow in bpf_kprobe_multi_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220516224934.GA5013@asgard.redhat.com>
Date:   Tue, 17 May 2022 00:49:34 +0200
From:   Eugene Syromiatnikov <esyr@...hat.com>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf 1/4] bpf_trace: check size for overflow in
 bpf_kprobe_multi_link_attach

On Mon, May 16, 2022 at 11:34:45PM +0200, Jiri Olsa wrote:
> On Mon, May 16, 2022 at 08:27:08PM +0200, Eugene Syromiatnikov wrote:
> > +	if (check_mul_overflow(cnt, sizeof(*syms), &size))
> > +		return -EOVERFLOW;
> 
> there was an update already:
> 
>   0236fec57a15 bpf: Resolve symbols with ftrace_lookup_symbols for kprobe multi link
> 
> so this won't apply anymore, could you please rebase on top of the latest bpf-next/master?

The issue that this specific check has to go in 4.18, as it covers
possible out-of-bounds write, I'm not sure how to handle it, have
a branch where it is merged manually?