linux-kernel - Re: [PATCH] topology: Remove unused cpu_cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4z=U=4mtkbjJKq3=_npLnqDtXnCwqr-9kbXkaRn4Jiydw@mail.gmail.com>
Date:   Mon, 16 May 2022 18:59:43 +1200
From:   Barry Song <21cnbao@...il.com>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] topology: Remove unused cpu_cluster_mask()

On Fri, May 13, 2022 at 9:48 PM Dietmar Eggemann
<dietmar.eggemann@....com> wrote:
>
> - Barry Song <song.bao.hua@...ilicon.com> bounced
> + Barry Song <21cnbao@...il.com>
>
> On 13/05/2022 11:34, Dietmar Eggemann wrote:
> > default_topology[] uses cpu_clustergroup_mask() for the CLS level
> > (guarded by CONFIG_SCHED_CLUSTER) which is currently provided by x86
> > (arch/x86/kernel/smpboot.c) and arm64 (drivers/base/arch_topology.c).
> >
> > Fixes: 778c558f49a2c ("sched: Add cluster scheduler level in core and
> > related Kconfig for ARM64")
> >
> > Signed-off-by: Dietmar Eggemann <dietmar.eggemann@....com>
> > ---
> >  include/linux/topology.h | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/include/linux/topology.h b/include/linux/topology.h
> > index f19bc3626297..4564faafd0e1 100644
> > --- a/include/linux/topology.h
> > +++ b/include/linux/topology.h
> > @@ -240,13 +240,6 @@ static inline const struct cpumask *cpu_smt_mask(int cpu)
> >  }
> >  #endif
> >
> > -#if defined(CONFIG_SCHED_CLUSTER) && !defined(cpu_cluster_mask)
> > -static inline const struct cpumask *cpu_cluster_mask(int cpu)
> > -{
> > -     return topology_cluster_cpumask(cpu);
> > -}
> > -#endif
> > -

Acked-by: Barry Song <baohua@...nel.org>

I agree there are no users right now. I probably wrote it like cpu_smt_mask()
and used it in kernel/sched for the wake_affine patch but forgot to remove it
while sending patches without wake_affine.


> >  static inline const struct cpumask *cpu_cpu_mask(int cpu)
> >  {
> >       return cpumask_of_node(cpu_to_node(cpu));
>

Thanks
Barry