linux-kernel - Re: [PATCH -next] mtd: st_spi_fsm: add missing clk_disable_unprepare() stfsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220516095108.4ec6d0d9@xps13>
Date:   Mon, 16 May 2022 09:51:08 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <richard@....at>, <vigneshr@...com>
Subject: Re: [PATCH -next] mtd: st_spi_fsm: add missing
 clk_disable_unprepare() stfsm_remove()

Hello,

yangyingliang@...wei.com wrote on Sat, 14 May 2022 10:12:55 +0800:

> Hi,
> 
> On 2022/5/13 18:22, Miquel Raynal wrote:
> > Hi,
> >
> > yangyingliang@...wei.com wrote on Fri, 13 May 2022 18:03:22 +0800:
> >  
> >> Clock source is prepared and enabled by clk_prepare_enable()
> >> in probe function, but no disable or unprepare in remove function.  
> > 			 not disabled or unprepared
> >
> > Otherwise looks good.  
> Do I need to resend it ?

Yes, please.

Thanks,
Miquèl