linux-kernel - Re: [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for sun8i-r40 based board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220516075326.hccburhu743t7p6r@houat>
Date:   Mon, 16 May 2022 09:53:26 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     qianfan <qianfanguijin@....com>
Cc:     linux-sunxi@...ts.linux.dev, Rob Herring <robh+dt@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: dts: sun8i-r40: Add "cpu-supply" node for
 sun8i-r40 based board

On Fri, May 13, 2022 at 04:23:20PM +0800, qianfan wrote:
> > > > There's a similar issue for all the boards that don't have a regulator
> > > > in the first place.
> > > > 
> > > > The way we worked around this for the other SoCs is to have a DTSI with
> > > > the OPPs with a frequency higher than what U-Boot boots with (1008MHz?),
> > > > and only include that DTSI on boards that have a CPU regulator hooked in.
> > > Is this really necessary? It seems like every board based on sun8i-r40
> > > have a cpu regulator.
> > This probably won't be the case whenever someone starts a new design,
> > and then they'll face random crashes for no apparent reason, and waste a
> > lot of time in the process.
> > 
> > Whereas the alternative is that you would be missing some OPPs,
> > something that is fairly easy to figure out.
>
> How about remove the OPPs which greate that 1.08G in sun8i-r40.dtsi,
> If some boards want to run at a higher frequency, can add them byself
> in the board's file.

You did all the work to support and test them already. It's a bit of a
waste to do that and not include it.

Just do a DTSI like we did for the A64 for example.

Maxime