linux-kernel - Re: ERROR: drivers: iscsi: iscsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0db186ce-f789-f306-46ed-74ba75dec028@prevas.dk>
Date:   Mon, 16 May 2022 10:47:53 +0200
From:   Rasmus Villemoes <rasmus.villemoes@...vas.dk>
To:     Test Bot <zgrieee@...il.com>, linux-kernel@...r.kernel.org
Cc:     martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: ERROR: drivers: iscsi: iscsi_target.c

On 12/05/2022 20.42, Test Bot wrote:
> Hi,
> 
> I automatically test (RC) kernel and caught ERROR word.
> Please ignore, if its unimportant.
> 
> Kernel: 5.18-rc6
> Arch: x86_64 (SMP)
> Compiler: 7.5.0 (gcc)
> 
> Codebase Block:
> 
> void iscsit_thread_get_cpumask(struct iscsi_conn *conn)
> {
>         int ord, cpu;
>         cpumask_t conn_allowed_cpumask;
> 
>         cpumask_and(&conn_allowed_cpumask, iscsit_global->allowed_cpumask,
>                     cpu_online_mask);
> 
>        cpumask_clear(conn->conn_cpumask);
>         ord = conn->bitmap_id % cpumask_weight(&conn_allowed_cpumask);
>         for_each_cpu(cpu, &conn_allowed_cpumask) {
>                 if (ord-- == 0) {
>                         cpumask_set_cpu(cpu, conn->conn_cpumask);
>                         return;
>                 }
>         }
>         dump_stack();
>         cpumask_setall(conn->conn_cpumask);
> }

Hm, looks like cpumask.h should also expose a wrapper for
bitmap_ord_to_pos ...

Rasmus