linux-kernel - Re: [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 May 2022 11:58:49 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Anson Huang <Anson.Huang@....com>, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: imx_sc_thermal: Fix refcount leak in
 imx_sc_thermal_probe

On 16/05/2022 09:31, Miaoqian Lin wrote:
> of_find_node_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>   drivers/thermal/imx_sc_thermal.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index 8d76dbfde6a9..1ab854c228e5 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>   		if (!sensor) {
>   			of_node_put(child);
>   			of_node_put(sensor_np);
> +			of_node_put(np);
>   			return -ENOMEM;
>   		}


Please use goto statement

> @@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>   	}
>   
>   	of_node_put(sensor_np);
> +	of_node_put(np);
>   
>   	return ret;
>   }


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog