linux-kernel - Re: [PATCH] btrfs: Fix an error handling path in btrfs_read_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220516135407.GM4009@kadam>
Date:   Mon, 16 May 2022 16:54:07 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Qu Wenruo <quwenruo.btrfs@....com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, Qu Wenruo <wqu@...e.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH] btrfs: Fix an error handling path in
 btrfs_read_sys_array()

On Sun, May 15, 2022 at 06:57:25AM +0800, Qu Wenruo wrote:
> 
> 
> On 2022/5/14 20:01, Christophe JAILLET wrote:
> > If alloc_dummy_extent_buffer() we should return an error code, not 0 that
> > would mean success.
> > 
> > Fixes: a1fc41ac28d3 ("btrfs: use dummy extent buffer for super block sys chunk array read")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Reviewed-by: Qu Wenruo <wqu@...e.com>
> 
> All my fault, thanks for catching it.
> Qu
> 

I sent this patch in January and David was going to fold it into the
original patch but it got lost.  Thanks, Christophe!

regards,
dan carpenter