lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2022 15:55:18 +0200 From: Ulf Hansson <ulf.hansson@...aro.org> To: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com> Cc: Michal Simek <michal.simek@...inx.com>, Adrian Hunter <adrian.hunter@...el.com>, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, git@...inx.com, saikrishna12468@...il.com, sgoud@...inx.com Subject: Re: [PATCH] mmc: sdhci-of-arasan: Add NULL check for data field On Thu, 12 May 2022 at 09:20, Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com> wrote: > > Add NULL check for data field retrieved from of_device_get_match_data() > before dereferencing the data. > Addresses-coverity: CID 305057:Dereference null return value (NULL_RETURNS) > > Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-arasan.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 6a2e5a468424..757801dfc308 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -1577,6 +1577,9 @@ static int sdhci_arasan_probe(struct platform_device *pdev) > const struct sdhci_arasan_of_data *data; > > data = of_device_get_match_data(dev); > + if (!data) > + return -EINVAL; > + > host = sdhci_pltfm_init(pdev, data->pdata, sizeof(*sdhci_arasan)); > > if (IS_ERR(host)) > -- > 2.17.1 >
Powered by blists - more mailing lists