linux-kernel - Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220516150237.v3xt7onp2lpmellw@uno.localdomain>
Date:   Mon, 16 May 2022 17:02:37 +0200
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Hugues Fruchet <hugues.fruchet@...s.st.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        Alain Volmat <alain.volmat@...s.st.com>,
        Yannick Fertre <yannick.fertre@...s.st.com>,
        Philippe CORNU <philippe.cornu@...s.st.com>
Subject: Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel
 formats variant

Hi Hugues,

On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
> From: Hugues Fruchet <hugues.fruchet@...com>
>
> Add support of 1X16 serial pixel formats in order to support
> CSI-2 camera sensor exposing 1x16 pixel formats only.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@...com>

Reviewed-by: Jacopo Mondi <jacopo@...ndi.org>

Sakari, if you're sending a new pull request for the ov5640 series,
could you include this one as otherwise dcmi would be broken when used
with that sensor.

Thanks
   j

> ---
>  drivers/media/platform/st/stm32/stm32-dcmi.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 09a743cd7004..b2ba4d95bfa3 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -1592,25 +1592,31 @@ static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi)
>  	return 0;
>  }
>
> -/*
> - * FIXME: For the time being we only support subdevices
> - * which expose RGB & YUV "parallel form" mbus code (_2X8).
> - * Nevertheless, this allows to support serial source subdevices
> - * and serial to parallel bridges which conform to this.
> - */
>  static const struct dcmi_format dcmi_formats[] = {
>  	{
>  		.fourcc = V4L2_PIX_FMT_RGB565,
>  		.mbus_code = MEDIA_BUS_FMT_RGB565_2X8_LE,
>  		.bpp = 2,
> +	}, {
> +		.fourcc = V4L2_PIX_FMT_RGB565,
> +		.mbus_code = MEDIA_BUS_FMT_RGB565_1X16,
> +		.bpp = 2,
>  	}, {
>  		.fourcc = V4L2_PIX_FMT_YUYV,
>  		.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8,
>  		.bpp = 2,
> +	}, {
> +		.fourcc = V4L2_PIX_FMT_YUYV,
> +		.mbus_code = MEDIA_BUS_FMT_YUYV8_1X16,
> +		.bpp = 2,
>  	}, {
>  		.fourcc = V4L2_PIX_FMT_UYVY,
>  		.mbus_code = MEDIA_BUS_FMT_UYVY8_2X8,
>  		.bpp = 2,
> +	}, {
> +		.fourcc = V4L2_PIX_FMT_UYVY,
> +		.mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
> +		.bpp = 2,
>  	}, {
>  		.fourcc = V4L2_PIX_FMT_JPEG,
>  		.mbus_code = MEDIA_BUS_FMT_JPEG_1X8,
> --
> 2.25.1
>