linux-kernel - Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 May 2022 17:06:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Rob Herring <robh@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Alexandru M Stan <amstan@...omium.org>,
        Julius Werner <jwerner@...omium.org>,
        "Joseph S . Barrera III" <joebar@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add sc7180 Chromebook
 board bindings

On 16/05/2022 17:01, Doug Anderson wrote:
> 
> 
>> Actually this change should be rather part of that other commit...
> 
> I'm not sure I understand. Which of these are you suggesting?
> 
> 1. You want me to squash the two commits into one, so we add the
> generic doc in the same patch as the one adding sc7180 Chromebooks.
> 
> 2. You want the generic doc to come first in the series and it just
> adds the little blurb into
> "Documentation/devicetree/bindings/arm/qcom.yaml" even though
> Chromebooks aren't actually added until a later commit in the series.
> 
> 3. You want to add the sc7180 Chromebooks first in the series with no
> documentation and then later add in the generic documentation and the
> blurb into "Documentation/devicetree/bindings/arm/qcom.yaml".

Sorry for being unclear, I propose the third option. I mean, the hunk
referencing "chromebook-boot-flow.rst" should be rather added by the
patch adding that document.

> I'm also interested to know if you think the generic documentation
> patch should land through the Qualcomm tree. I think it would
> absolutely have to if I take your suggestion, right?

Yes, in that case would be a 5th patch in the set here, so I think
everything would go via Qcom SoC.


Best regards,
Krzysztof