linux-kernel - Re: [PATCH -next v2] mtd: st_spi_fsm: add missing clk_disable_unprepare() in stfsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220516184348.77f5b39d@xps-13>
Date:   Mon, 16 May 2022 18:43:48 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <richard@....at>, <vigneshr@...com>
Subject: Re: [PATCH -next v2] mtd: st_spi_fsm: add missing
 clk_disable_unprepare() in stfsm_remove()

Hi Yang,

yangyingliang@...wei.com wrote on Mon, 16 May 2022 17:29:11 +0800:

> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but not disabled or unprepared in remove
> function.
> 

Applied to mtd/next, thanks!

> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> v2:
>   make the commit message and title more proper.
> ---
>  drivers/mtd/devices/st_spi_fsm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 983999c020d6..d3377b10fc0f 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -2126,6 +2126,8 @@ static int stfsm_remove(struct platform_device *pdev)
>  {
>  	struct stfsm *fsm = platform_get_drvdata(pdev);
>  
> +	clk_disable_unprepare(fsm->clk);
> +
>  	return mtd_device_unregister(&fsm->mtd);
>  }
>  


Thanks,
Miquèl