linux-kernel - Re: [PATCH v2 2/2] nvmem: microchip-otpc: add support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79dcb6b9-e983-15ee-709b-878c889bfe4d@linaro.org>
Date:   Tue, 17 May 2022 16:08:55 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        srinivas.kandagatla@...aro.org, robh+dt@...nel.org,
        krzk+dt@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] nvmem: microchip-otpc: add support

On 17/05/2022 14:58, Claudiu Beznea wrote:

Thank you for your patch. There is something to discuss/improve.

> +static const struct of_device_id mchp_otpc_ids[] = {
> +	{ .compatible = "microchip,sama7g5-otpc", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, mchp_otpc_ids);
> +
> +static struct platform_driver mchp_otpc_driver = {
> +	.probe = mchp_otpc_probe,
> +	.driver = {
> +		.name = MCHP_OTPC_NAME,
> +		.of_match_table = of_match_ptr(mchp_otpc_ids),

This still has incorrect pair of of_match_ptr/maybe_unused. Either both,
or none.


Best regards,
Krzysztof