linux-kernel - Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a33ab7b9-738f-db91-f6ba-78a9641365e8@amd.com>
Date:   Tue, 17 May 2022 10:13:17 -0400
From:   Andrey Grodzovsky <andrey.grodzovsky@....com>
To:     Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        Erico Nunes <nunes.erico@...il.com>,
        Steven Price <steven.price@....com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Rob Herring <robh@...nel.org>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
        Rob Clark <robdclark@...il.com>,
        Dmitry Osipenko <digetx@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

Done.

Andrey

On 2022-05-17 10:03, Andrey Grodzovsky wrote:
> Let me push it into drm-misc-next.
>
> Andrey
>
> On 2022-05-17 05:03, Dmitry Osipenko wrote:
>
>> On 5/17/22 10:40, Erico Nunes wrote:
>>> On Wed, Apr 13, 2022 at 12:05 PM Steven Price <steven.price@....com> 
>>> wrote:
>>>> On 11/04/2022 23:15, Dmitry Osipenko wrote:
>>>>> Interrupt context can't sleep. Drivers like Panfrost and MSM are 
>>>>> taking
>>>>> mutex when job is released, and thus, that code can sleep. This 
>>>>> results
>>>>> into "BUG: scheduling while atomic" if locks are contented while 
>>>>> job is
>>>>> freed. There is no good reason for releasing scheduler's jobs in IRQ
>>>>> context, hence use normal context to fix the trouble.
>>>>>
>>>>> Cc: stable@...r.kernel.org
>>>>> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a 
>>>>> processes")
>>>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
>>>> Reviewed-by: Steven Price <steven.price@....com>
>>> Is there something blocking this patch?
>>> Mesa CI is still hitting the issue and I have been waiting for it to
>>> be applied/backported to update CI with it.
>>> Thanks
>> If this patch won't be picked up anytime soon, then I'll include it into
>> my "memory shrinker" patchset together with the rest of the fixes, so it
>> won't get lost.
>>