linux-kernel - Re: [PATCH v4] ARM: module: Add all unwind tables when load module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk>
Date:   Tue, 17 May 2022 15:19:00 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Chen Zhongjin <chenzhongjin@...wei.com>
Cc:     alexander.sverdlin@...ia.com, ardb@...nel.org,
        linus.walleij@...aro.org, nico@...xnic.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module

Hi,

On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote:
>  struct mod_arch_specific {
>  #ifdef CONFIG_ARM_UNWIND
> -	struct unwind_table *unwind[ARM_SEC_MAX];
> +	struct unwind_table unwind_list;

Why is this not a:

	struct list_head unwind_list;

because, from what I can tell, the _only_ member that is used in this
struct unwind_table is the "mod_list" member - so everything else is
entirely unused and redundant.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!