linux-kernel - Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 11:04:13 -0400
From:   Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        matthias.bgg@...il.com, sboyd@...nel.org,
        chun-jie.chen@...iatek.com, rex-bc.chen@...iatek.com,
        wenst@...omium.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary
 'items'

On Tue, May 17, 2022 at 12:15:13PM +0200, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
> 
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../arm/mediatek/mediatek,mt8192-clock.yaml   | 45 +++++++++----------
>  1 file changed, 22 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..bb410b178f33 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -14,29 +14,28 @@ description:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - mediatek,mt8192-scp_adsp
> -          - mediatek,mt8192-imp_iic_wrap_c
> -          - mediatek,mt8192-imp_iic_wrap_e
> -          - mediatek,mt8192-imp_iic_wrap_s
> -          - mediatek,mt8192-imp_iic_wrap_ws
> -          - mediatek,mt8192-imp_iic_wrap_w
> -          - mediatek,mt8192-imp_iic_wrap_n
> -          - mediatek,mt8192-msdc_top
> -          - mediatek,mt8192-msdc
> -          - mediatek,mt8192-mfgcfg
> -          - mediatek,mt8192-imgsys
> -          - mediatek,mt8192-imgsys2
> -          - mediatek,mt8192-vdecsys_soc
> -          - mediatek,mt8192-vdecsys
> -          - mediatek,mt8192-vencsys
> -          - mediatek,mt8192-camsys
> -          - mediatek,mt8192-camsys_rawa
> -          - mediatek,mt8192-camsys_rawb
> -          - mediatek,mt8192-camsys_rawc
> -          - mediatek,mt8192-ipesys
> -          - mediatek,mt8192-mdpsys
> +    enum:
> +      - mediatek,mt8192-scp_adsp
> +      - mediatek,mt8192-imp_iic_wrap_c
> +      - mediatek,mt8192-imp_iic_wrap_e
> +      - mediatek,mt8192-imp_iic_wrap_s
> +      - mediatek,mt8192-imp_iic_wrap_ws
> +      - mediatek,mt8192-imp_iic_wrap_w
> +      - mediatek,mt8192-imp_iic_wrap_n
> +      - mediatek,mt8192-msdc_top
> +      - mediatek,mt8192-msdc
> +      - mediatek,mt8192-mfgcfg
> +      - mediatek,mt8192-imgsys
> +      - mediatek,mt8192-imgsys2
> +      - mediatek,mt8192-vdecsys_soc
> +      - mediatek,mt8192-vdecsys
> +      - mediatek,mt8192-vencsys
> +      - mediatek,mt8192-camsys
> +      - mediatek,mt8192-camsys_rawa
> +      - mediatek,mt8192-camsys_rawb
> +      - mediatek,mt8192-camsys_rawc
> +      - mediatek,mt8192-ipesys
> +      - mediatek,mt8192-mdpsys

This will conflict with the patch removing msdc:

[1] https://lore.kernel.org/all/20220429123133.28869-1-matthias.bgg@kernel.org/

Although if this series is merged before that one, it should be fine.

Thanks,
Nícolas