linux-kernel - Re: [PATCH V10 14/22] LoongArch: Add signal handling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v8u49nn3.fsf@email.froward.int.ebiederm.org>
Date:   Tue, 17 May 2022 10:36:48 -0500
From:   "Eric W. Biederman" <ebiederm@...ssion.com>
To:     Huacai Chen <chenhuacai@...il.com>
Cc:     WANG Xuerui <kernel@...0n.name>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "<linux-arch@...r.kernel.org>" <linux-arch@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Guo Ren <guoren@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH V10 14/22] LoongArch: Add signal handling support

Huacai Chen <chenhuacai@...il.com> writes:

> Hi, Eric,
>
> On Mon, May 16, 2022 at 10:07 PM Eric W. Biederman
> <ebiederm@...ssion.com> wrote:
>>
>> I can understand exporting these values but the names aren't very
>> well namespaced at all.  Which means they could accidentially
>> conflict with things.
>>
>> It would probably be better to do:
>> SC_USED_FP
>> SC_ADDRERR_RD
>> SC_ADDRERR_WR
> SC_ prefix is good, but ADRERR_RD/ADRERR_WR is used together with
> SIGSEGV/SIGBUS, so I want to keep the same as BUS_ADRERR (a single D)
> if possible.

Fair enough about the single D.  Please add the prefix in the next
version. Especially for kabi symbols in a namespace is a very good idea.


>> Given that neither lsx_context nor lasx_context are used in the kernel
>> code yet I would very much prefer that their inclusion wait until there
>> is actual code that needs them.
>>
>> If nothing else that will put the definitions in context so people can
>> more easily see the big picture and understand how the pieces fit.
> OK, I will remove lsx_context/lasx_context in the next version.

Thanks,
Eric