[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e51a64cd-1130-9c65-2bde-483c63f6aa10@hartkopp.net>
Date: Tue, 17 May 2022 17:50:03 +0200
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Max Staudt <max@...as.org>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
Vincent MAILHOL <mailhol.vincent@...adoo.fr>,
linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and
can_skb_headroom_valid to skb.c
On 17.05.22 17:38, Max Staudt wrote:
> On Tue, 17 May 2022 16:35:05 +0200
> Oliver Hartkopp <socketcan@...tkopp.net> wrote:
>
>> I think it should be even more simple.
>>
>> When you enter the current Kconfig page of "CAN Device Drivers" every
>> selection of vcan/vxcan/slcan should directly select CAN_DEV_SW.
>
> I'm a bit lost - what would CAN_DEV_SW do?
It should be just *one* enabler of building can-dev-ko
> If it enables can_dropped_invalid_skb(), then the HW drivers would also
> need to depend on CAN_DEV_SW directly or indirectly, or am I missing
> something?
And CAN_DEV is another enabler that would build the skb stuff from
CAN_DEV_SW too (but also the netlink stuff).
That's what I meant with "some Makefile magic" which is then building
the can-dev.ko with the required features depending on CAN_DEV_SW,
CAN_DEV, CAN_DEV_RX_OFFLOAD, CAN_CALC_BITTIMING, etc
Best,
Oliver
Powered by blists - more mailing lists