linux-kernel - Re: [PATCH v0] ASoC: rt5645: Fix errorenous cleanup order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165280316877.1635268.8412157029649432133.b4-ty@kernel.org>
Date:   Tue, 17 May 2022 16:59:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     linma@....edu.cn, tiwai@...e.com, oder_chiou@...ltek.com,
        alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v0] ASoC: rt5645: Fix errorenous cleanup order

On Mon, 16 May 2022 17:20:35 +0800, Lin Ma wrote:
> There is a logic error when removing rt5645 device as the function
> rt5645_i2c_remove() first cancel the &rt5645->jack_detect_work and
> delete the &rt5645->btn_check_timer latter. However, since the timer
> handler rt5645_btn_check_callback() will re-queue the jack_detect_work,
> this cleanup order is buggy.
> 
> That is, once the del_timer_sync in rt5645_i2c_remove is concurrently
> run with the rt5645_btn_check_callback, the canceled jack_detect_work
> will be rescheduled again, leading to possible use-after-free.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5645: Fix errorenous cleanup order
      commit: 2def44d3aec59e38d2701c568d65540783f90f2f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark