[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <21250bc0-623b-f11d-7dbf-458d144b7963@pengutronix.de>
Date: Tue, 17 May 2022 19:52:51 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: James Bottomley <jejb@...ux.ibm.com>,
Jarkko Sakkinen <jarkko@...nel.org>,
Mimi Zohar <zohar@...ux.ibm.com>,
David Howells <dhowells@...hat.com>, kernel@...gutronix.de,
Sumit Garg <sumit.garg@...aro.org>,
Pankaj Gupta <pankaj.gupta@....com>,
David Gstir <david@...ma-star.at>,
Michael Walle <michael@...le.cc>,
John Ernberg <john.ernberg@...ia.se>,
James Morris <jmorris@...ei.org>,
"Serge E. Hallyn" <serge@...lyn.com>,
Horia Geantă <horia.geanta@....com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Jan Luebbe <j.luebbe@...gutronix.de>,
Eric Biggers <ebiggers@...nel.org>,
Richard Weinberger <richard@....at>,
Franck LENORMAND <franck.lenormand@....com>,
Matthias Schiffer <matthias.schiffer@...tq-group.com>,
keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org
Subject: Re: [PATCH v10 2/7] KEYS: trusted: allow use of kernel RNG for key
material
Hello Jason,
On 17.05.22 19:27, Jason A. Donenfeld wrote:
> On Fri, May 13, 2022 at 04:57:00PM +0200, Ahmad Fatoum wrote:
>> + trusted.rng= [KEYS]
>> + Format: <string>
>> + The RNG used to generate key material for trusted keys.
>> + Can be one of:
>> + - "kernel"
>> + - the same value as trusted.source: "tpm" or "tee"
>> + - "default"
>> + If not specified, "default" is used. In this case,
>> + the RNG's choice is left to each individual trust source.
>> +
>
> As a general mechanism, I object to this. The kernel's RNG must be
> trusted in the first place for key material. That's the whole point of
> it.
>
> However, it sounds like you're not proposing a general mechanism, but
> just something particular to this "trusted keys" business.
The two currently upstream trust sources (trusted key backends) each provide
their own RNG callback. This series adds a third backend that uses kernel RNG
and additionally provides users of the two existing trust sources the option
to benefit from kernel RNG as well.
> this should be a module flag, and thus not documented here, but rather
> some place namespaced to your trusted keys stuff. "trusted_keys.preferred_rng={whatever}"
The trusted keys module is trusted.ko and directly before my added lines is
the trusted.source= documentation, so I think this is already at the correct place.
Thanks,
Ahmad
>
> Jason
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists