linux-kernel - Re: [PATCH bpf-next] selftests/bpf: Add missing trampoline program type to trampoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9560ec84-9b05-63f9-0090-590c0f1bd6c1@fb.com>
Date:   Mon, 16 May 2022 19:49:23 -0700
From:   Yonghong Song <yhs@...com>
To:     Yuntao Wang <ytcoode@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Cc:     Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Yucong Sun <sunyucong@...il.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Kui-Feng Lee <kuifeng@...com>, Jiri Olsa <jolsa@...nel.org>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Add missing trampoline program
 type to trampoline_count test



On 5/14/22 11:31 PM, Yuntao Wang wrote:
> Currently the trampoline_count test doesn't include any fmod_ret bpf
> programs, fix it to make the test cover all possible trampoline program
> types.
> 
> Since fmod_ret bpf programs can't be attached to __set_task_comm function,
> as it's neither whitelisted for error injection nor a security hook, change
> it to bpf_modify_return_test.
> 
> This patch also does some other cleanups such as removing duplicate code,
> dropping inconsistent comments, etc.
> 
> Signed-off-by: Yuntao Wang <ytcoode@...il.com>

Acked-by: Yonghong Song <yhs@...com>