linux-kernel - Re: [PATCH v6 2/7] dt-bindings: thermal: Add binding document for mt6873 thermal controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220517175958.GA1321687-robh@kernel.org>
Date:   Tue, 17 May 2022 12:59:58 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Alexandre Bailon <abailon@...libre.com>, krzk+dt@...nel.org,
        matthias.bgg@...il.com, p.zabel@...gutronix.de, rafael@...nel.org,
        daniel.lezcano@...aro.org, amitk@...nel.org, rui.zhang@...el.com,
        michael.kao@...iatek.com, ben.tseng@...iatek.com,
        ethan.chang@...iatek.com, frank-w@...lic-files.de,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, khilman@...libre.com
Subject: Re: [PATCH v6 2/7] dt-bindings: thermal: Add binding document for
 mt6873 thermal controller

On Thu, May 12, 2022 at 04:25:51PM +0200, Krzysztof Kozlowski wrote:
> On 12/05/2022 14:24, Alexandre Bailon wrote:
> > From: Michael Kao <michael.kao@...iatek.com>
> > 
> > This patch adds binding document for mt6873 thermal controller.
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> > 
> > Signed-off-by: Michael Kao <michael.kao@...iatek.com>
> > Signed-off-by: Ben Tseng <ben.tseng@...iatek.com>
> > ---
> >  .../thermal/mediatek-thermal-lvts.yaml        | 81 +++++++++++++++++++
> >  1 file changed, 81 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> > new file mode 100644
> > index 000000000000..69ffe7b14c21
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> 
> filename: vendor,device
> so something like mediatek,mt6873-lvts.yaml or
> mediatek,mt6873-lvts-thermal.yaml
> 
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/mediatek-thermal-lvts.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek SoC LVTS thermal controller (DTS) binding
> 
> s/(DTS) binding//
> (unless DTS means something related to hardware)
> 
> > +
> > +maintainers:
> > +  - Yu-Chia Chang <ethan.chang@...iatek.com>
> > +  - Ben Tseng <ben.tseng@...iatek.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt6873-lvts
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: lvts_clk
> 
> Skip "_clk" suffix, so just lvts.

Or drop altogether. There's generally no good name when there's only one 
entry so folks just make up 'clk', 'phy', 'rst', etc. or $block for the 
name.

Rob