linux-kernel - Re: [PATCH] drm: dp: fix a possible memory leak in fetch_monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <876ef490a577b8af71d1a8d24a55e43616b7d45b.camel@redhat.com>
Date:   Tue, 17 May 2022 15:52:56 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Hangyu Hua <hbh25y@...il.com>, airlied@...ux.ie, daniel@...ll.ch,
        tzimmermann@...e.de, jani.nikula@...el.com,
        Bhawanpreet.Lakha@....com, Wayne.Lin@....com
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: dp: fix a possible memory leak in
 fetch_monitor_name()

Reviewed-by: Lyude Paul <lyude@...hat.com>

Will push to the appropriate branch in a bit

On Mon, 2022-05-16 at 11:20 +0800, Hangyu Hua wrote:
> drm_dp_mst_get_edid call kmemdup to create mst_edid. So mst_edid need to be
> freed after use.
> 
> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> ---
>  drivers/gpu/drm/dp/drm_dp_mst_topology.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> b/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> index 11300b53d24f..7a7cc44686f9 100644
> --- a/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/dp/drm_dp_mst_topology.c
> @@ -4852,6 +4852,7 @@ static void fetch_monitor_name(struct
> drm_dp_mst_topology_mgr *mgr,
>  
>         mst_edid = drm_dp_mst_get_edid(port->connector, mgr, port);
>         drm_edid_get_monitor_name(mst_edid, name, namelen);
> +       kfree(mst_edid);
>  }
>  
>  /**

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat