linux-kernel - Re: [PATCH] Input: sparcspkr: Fix refcount leak in bbc_beep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf778cef-d09a-5fcd-8388-d77690ac87c6@gmail.com>
Date:   Tue, 17 May 2022 13:39:33 +0800
From:   Miaoqian Lin <linmq006@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: sparcspkr: Fix refcount leak in bbc_beep_probe

Hi, Dmitry

On 2022/5/17 6:08, Dmitry Torokhov wrote:
> Hi 
> On Mon, May 16, 2022 at 12:10:16PM +0400, Miaoqian Lin wrote:
>> of_find_node_by_path() calls of_find_node_opts_by_path(),
>> which returns a node pointer with refcount
>> incremented, we should use of_node_put() on it when done.
>> Add missing of_node_put() to avoid refcount leak.
>>
>> Fixes: 9c1a5077fdca ("input: Rewrite sparcspkr device probing.")
>> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
>> ---
> Thank you for the patch.
>
>>  drivers/input/misc/sparcspkr.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/input/misc/sparcspkr.c b/drivers/input/misc/sparcspkr.c
>> index fe43e5557ed7..6a86900aa1fb 100644
>> --- a/drivers/input/misc/sparcspkr.c
>> +++ b/drivers/input/misc/sparcspkr.c
>> @@ -206,11 +206,11 @@ static int bbc_beep_probe(struct platform_device *op)
>>  	info = &state->u.bbc;
>>  	info->clock_freq = of_getintprop_default(dp, "clock-frequency", 0);
>>  	if (!info->clock_freq)
>> -		goto out_free;
>> +		goto out_put;
>>  
>>  	info->regs = of_ioremap(&op->resource[0], 0, 6, "bbc beep");
>>  	if (!info->regs)
>> -		goto out_free;
>> +		goto out_put;
>>  
>>  	platform_set_drvdata(op, state);
>>  
>> @@ -218,11 +218,14 @@ static int bbc_beep_probe(struct platform_device *op)
>>  	if (err)
>>  		goto out_clear_drvdata;
>>  
>> +	of_node_put(dp);
>> +
> We do not really need to keep node pointer for that long, how about the
> version of your patch below?
Looks good to me.
> Thanks.
>