linux-kernel - Re: [PATCH] sparse: use force attribute for fmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YoNDA0SOFjyoFlJS@infradead.org>
Date:   Mon, 16 May 2022 23:38:59 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Vasily Averin <vvs@...nvz.org>
Cc:     Jan Kara <jack@...e.cz>, Alexander Viro <viro@...iv.linux.org.uk>,
        kernel@...nvz.org, linux-kernel@...r.kernel.org,
        Amir Goldstein <amir73il@...il.com>,
        Matthew Bobrowski <repnop@...gle.com>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] sparse: use force attribute for fmode_t casts

Please just use __FMODE_NONOTIFY instead, which might be a bit misnamed,
but was added exactly for this kind of use.

And remember once more:  __force casts are a massive code smell.  Never
add them before thinking hard about them and adding a comment explaining
why they can't be avoided, preferably in a dedicated helper.