linux-kernel - Re: [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non power of 2 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR04MB741673F9764EFCA93F1932809BCE9@PH0PR04MB7416.namprd04.prod.outlook.com>
Date:   Tue, 17 May 2022 06:53:40 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Pankaj Raghav <p.raghav@...sung.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "pankydev8@...il.com" <pankydev8@...il.com>,
        "dsterba@...e.com" <dsterba@...e.com>, "hch@....de" <hch@....de>
CC:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "jiangbo.365@...edance.com" <jiangbo.365@...edance.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "gost.dev@...sung.com" <gost.dev@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non
 power of 2 compatible

On 16/05/2022 18:54, Pankaj Raghav wrote:
>  	/* Cache the sb zone number */
>  	for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; ++i) {
>  		zone_info->sb_zone_location[i] =
> -			sb_zone_number(zone_info->zone_size_shift, i);
> +			sb_zone_number(bdev, i);

I think this easily fits on one line now, doesn't it? But given David's
statement, it'll probably can go away anyways.