linux-kernel - Re: [PATCH] clk: at91: generated: consider range when calculating best rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d1a4b6c-cafa-b864-ba56-3e62f39cebf2@microchip.com>
Date:   Tue, 17 May 2022 08:04:06 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <sboyd@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <mturquette@...libre.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Claudiu.Beznea@...rochip.com>
Subject: Re: [PATCH] clk: at91: generated: consider range when calculating
 best rate

On 17.05.2022 10:14, Stephen Boyd wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Quoting Codrin.Ciubotariu@...rochip.com (2022-04-26 00:24:15)
>> On 22.04.2022 04:12, Stephen Boyd wrote:
>>> Quoting Codrin Ciubotariu (2022-04-13 00:13:18)
>>>> clk_generated_best_diff() helps in finding the parent and the divisor to
>>>> compute a rate closest to the required one. However, it doesn't take into
>>>> account the request's range for the new rate. Make sure the new rate
>>>> is within the required range.
>>>>
>>>> Fixes: 8a8f4bf0c480 ("clk: at91: clk-generated: create function to find best_diff")
>>>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
>>>> ---
>>>
>>> Is this fixing anything real or it's just a thing that you noticed and
>>> sent a patch to fix?
>>
>> It fixes the clk_set_min/max_rate() calls to a generated clock. Do you
>> want me to add this fact in the commit description?
>>
> 
> I wanted to know if there are clk_set_min/max_rate() calls on this clk.
> Are there?

Yes, there are:
https://elixir.bootlin.com/linux/latest/source/sound/soc/atmel/mchp-spdifrx.c#L450

Best regards,
Codrin