linux-kernel - Re: [RFC PATCH 2/2] Removes the x86 dependency on the QAT drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 10:11:09 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     yoan.picchi@....com
Cc:     Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        qat-linux <qat-linux@...el.com>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 2/2] Removes the x86 dependency on the QAT drivers

On Mon, 16 May 2022 at 12:16, <yoan.picchi@....com> wrote:
>
> From: Yoan Picchi <yoan.picchi@....com>
>
> This dependency looks outdated. After the previous patch, we have been able
> to use this driver to encrypt some data and to create working VF on arm64.
>
> Signed-off-by: Yoan Picchi <yoan.picchi@....com>

Are you sure the driver is safe for non-coherent DMA as well?

> ---
>  drivers/crypto/qat/Kconfig | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index 4b90c0f22b03..88df2cf4cac9 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -17,7 +17,7 @@ config CRYPTO_DEV_QAT
>
>  config CRYPTO_DEV_QAT_DH895xCC
>         tristate "Support for Intel(R) DH895xCC"
> -       depends on X86 && PCI
> +       depends on PCI
>         select CRYPTO_DEV_QAT
>         help
>           Support for Intel(R) DH895xcc with Intel(R) QuickAssist Technology
> @@ -28,7 +28,7 @@ config CRYPTO_DEV_QAT_DH895xCC
>
>  config CRYPTO_DEV_QAT_C3XXX
>         tristate "Support for Intel(R) C3XXX"
> -       depends on X86 && PCI
> +       depends on PCI
>         select CRYPTO_DEV_QAT
>         help
>           Support for Intel(R) C3xxx with Intel(R) QuickAssist Technology
> @@ -39,7 +39,7 @@ config CRYPTO_DEV_QAT_C3XXX
>
>  config CRYPTO_DEV_QAT_C62X
>         tristate "Support for Intel(R) C62X"
> -       depends on X86 && PCI
> +       depends on PCI
>         select CRYPTO_DEV_QAT
>         help
>           Support for Intel(R) C62x with Intel(R) QuickAssist Technology
> @@ -50,7 +50,7 @@ config CRYPTO_DEV_QAT_C62X
>
>  config CRYPTO_DEV_QAT_4XXX
>         tristate "Support for Intel(R) QAT_4XXX"
> -       depends on X86 && PCI
> +       depends on PCI
>         select CRYPTO_DEV_QAT
>         help
>           Support for Intel(R) QuickAssist Technology QAT_4xxx
> @@ -61,7 +61,7 @@ config CRYPTO_DEV_QAT_4XXX
>
>  config CRYPTO_DEV_QAT_DH895xCCVF
>         tristate "Support for Intel(R) DH895xCC Virtual Function"
> -       depends on X86 && PCI
> +       depends on PCI
>         select PCI_IOV
>         select CRYPTO_DEV_QAT
>
> @@ -74,7 +74,7 @@ config CRYPTO_DEV_QAT_DH895xCCVF
>
>  config CRYPTO_DEV_QAT_C3XXXVF
>         tristate "Support for Intel(R) C3XXX Virtual Function"
> -       depends on X86 && PCI
> +       depends on PCI
>         select PCI_IOV
>         select CRYPTO_DEV_QAT
>         help
> @@ -86,7 +86,7 @@ config CRYPTO_DEV_QAT_C3XXXVF
>
>  config CRYPTO_DEV_QAT_C62XVF
>         tristate "Support for Intel(R) C62X Virtual Function"
> -       depends on X86 && PCI
> +       depends on PCI
>         select PCI_IOV
>         select CRYPTO_DEV_QAT
>         help
> --
> 2.25.1
>