linux-kernel - Re: [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202205170856.ko6UxqWi-lkp@intel.com>
Date:   Tue, 17 May 2022 09:00:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Piyush Malgujar <pmalgujar@...vell.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        sgarapati@...vell.com, sbalcerak@...vell.com, cchavva@...vell.com,
        Piyush Malgujar <pmalgujar@...vell.com>
Subject: Re: [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor
 logic changes

Hi Piyush,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linux/master linus/master v5.18-rc7 next-20220516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Piyush-Malgujar/drivers-i2c-thunderx-Marvell-thunderx-i2c-changes/20220511-213853
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: mips-randconfig-r025-20220516 (https://download.01.org/0day-ci/archive/20220517/202205170856.ko6UxqWi-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/56654d280f7c130d4f1d78eb8a3fa57fedc86b7b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Piyush-Malgujar/drivers-i2c-thunderx-Marvell-thunderx-i2c-changes/20220511-213853
        git checkout 56654d280f7c130d4f1d78eb8a3fa57fedc86b7b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/i2c/busses/i2c-octeon-platdrv.c:27:
>> drivers/i2c/busses/i2c-octeon-core.h:223:21: error: incomplete definition of type 'struct pci_dev'
           u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
                          ~~~~^
   include/asm-generic/pci_iomap.h:10:8: note: forward declaration of 'struct pci_dev'
   struct pci_dev;
          ^
   1 error generated.


vim +223 drivers/i2c/busses/i2c-octeon-core.h

   213	
   214	#define PCI_SUBSYS_DEVID_9XXX 0xB
   215	/**
   216	 * octeon_i2c_is_otx2 - check for chip ID
   217	 * @pdev: PCI dev structure
   218	 *
   219	 * Returns TRUE if OcteonTX2, FALSE otherwise.
   220	 */
   221	static inline bool octeon_i2c_is_otx2(struct pci_dev *pdev)
   222	{
 > 223		u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
   224	
   225		return (chip_id == PCI_SUBSYS_DEVID_9XXX);
   226	}
   227	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp