linux-kernel - Re: [PATCH -next] powerpc/book3e: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b169642-5d32-4135-93a7-4969515d1ab0@huawei.com>
Date:   Tue, 17 May 2022 19:31:54 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "paulus@...ba.org" <paulus@...ba.org>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] powerpc/book3e: Fix build error

On 2022/5/17 18:45, Christophe Leroy wrote:
> 
> 
> Le 17/05/2022 à 11:48, YueHaibing a écrit :
>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>>    early_get_first_memblock_info(__va(dt_ptr), &size);
>>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Add missing include file linux/of_fdt.h to fix this.
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Thats for fixing that.
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
> 
> It means we don't have any defconfig for 32 bits booke with 
> CONFIG_RELOCATABLE ?

Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs
> 
>> ---
>>   arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
>> index 08a984e29433..093da4dbdee1 100644
>> --- a/arch/powerpc/mm/nohash/fsl_book3e.c
>> +++ b/arch/powerpc/mm/nohash/fsl_book3e.c
>> @@ -36,6 +36,7 @@
>>   #include <linux/delay.h>
>>   #include <linux/highmem.h>
>>   #include <linux/memblock.h>
>> +#include <linux/of_fdt.h>
>>   
>>   #include <asm/io.h>
>>   #include <asm/mmu_context.h>