linux-kernel - Re: [PATCH v2 4/4] mux: lan966: Add support for flexcom mux controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220517115327.4139280-1-michael@walle.cc>
Date:   Tue, 17 May 2022 13:53:27 +0200
From:   Michael Walle <michael@...le.cc>
To:     peda@...ntia.se
Cc:     Manohar.Puri@...rochip.com, UNGLinuxDriver@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        devicetree@...r.kernel.org, kavyasree.kotagiri@...rochip.com,
        krzysztof.kozlowski+dt@...aro.org, lee.jones@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk, nicolas.ferre@...rochip.com,
        Michael Walle <michael@...le.cc>
Subject: Re: [PATCH v2 4/4] mux: lan966: Add support for flexcom mux controller

Hi,

>> +struct mux_lan966x {
>
> Why is the file named lan966, but then everything inside lan966x?

So I was about to reply to the bindings but since that question
came up here, too, I'll do it here.

IMHO the name "lan966" is super confusing and if I followed it
correctly, it was just invented because the DT guys don't want to
have a wildcard in the compatibles. But LAN966 isn't a real product,
just LAN9662 and LAN9668 is.

I'd really prefer to have a consistent naming. I've said it once
[1], having "lan966" (over lan966x) feels like cheating and is even
worse, because everyone would assume there is a thing named LAN966.
lan966x might lead the reader to think twice what the 'x' means.

So I'd prefer to have lan966x in the documentation and the drivers
and just "microchip,lan9668" or "microchip,lan9662" in the
compatibles.

-michael

[1] https://lore.kernel.org/linux-devicetree/d18291ff8d81f03a58900935d92115f2@walle.cc/