linux-kernel - Re: [PATCH] iio: imu: bmi160: Fix the error handling at bmi160_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhUBj=uq6HhzRpTUO_iqrFQeVjiKE0n0bJ6SMKw8ZTdvFkCEA@mail.gmail.com>
Date:   Tue, 17 May 2022 20:23:31 +0800
From:   Zheyu Ma <zheyuma97@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     lars@...afoo.de, andriy.shevchenko@...ux.intel.com,
        sean@...nix.com, linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: imu: bmi160: Fix the error handling at bmi160_chip_init()

On Sat, May 14, 2022 at 10:27 PM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Fri, 13 May 2022 22:35:13 +0800
> Zheyu Ma <zheyuma97@...il.com> wrote:
>
> > When the driver fails in bmi160_chip_init(), it should disable the
> > regulator.
> >
> > The following log shows it:
> >
> > [   18.709662] WARNING: CPU: 0 PID: 294 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0
> > [   18.712069] RIP: 0010:_regulator_put+0x3ec/0x4e0
> > [   18.716395] Call Trace:
> > [   18.716522]  <TASK>
> > [   18.716636]  regulator_bulk_free+0x82/0xe0
> > [   18.717077]  i2c_device_probe+0x6f0/0x800
> >
> > Fixes: 5dea3fb066f0 ("iio: imu: bmi160: added regulator support")
> > Signed-off-by: Zheyu Ma <zheyuma97@...il.com>
>
> Hi,
>
> Good find, but Tong Zhang got their first and the resulting patch
> fixes an additional issue missed in this fix. See below.

Thanks for your reply! I'll check the linux-next branch next time.

Zheyu Ma