linux-kernel - Re: [PATCH v2 1/5] arm: dts: Add node for NPCM Video Capture/Encode Engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnNmFqFXxDv=+uEze2LjV2eMSVbMyCp=uiTnrm3Z7Hm6j8SHg@mail.gmail.com>
Date:   Tue, 17 May 2022 09:55:52 +0800
From:   Kun-Fa Lin <milkfafa@...il.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, CS20 KWLiu <kwliu@...oton.com>,
        tmaimon77@...il.com, avifishman70@...il.com,
        openbmc@...ts.ozlabs.org, tali.perry1@...il.com,
        Marvin Lin <kflin@...oton.com>
Subject: Re: [PATCH v2 1/5] arm: dts: Add node for NPCM Video Capture/Encode Engine

Dear Paul,

Thanks for your review and comments.

> Could you please add the datasheet name and revision to the commit message?

It may not be appropriate since the datasheet is not public.

> What board did you test this on?

I tested on Nuvoton NPCM750 evaluation board.

>
> > Signed-off-by: Marvin Lin <kflin@...oton.com>
>
> As you sent this from your Google Mail account, that address is going to
> be used in the author field. Is your Nuvoton address configured for git?
>
>      git config user.email
>
> Then I would have thought, that that address is also in the files
> generated by `git format-patch`.

Thanks for the reminder. I'll change the address configuration.

Regards,
Marvin