linux-kernel - Re: [PATCH v2 5/5] drivers: media: platform: Add NPCM Video Capture/Encode Engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YoOje2L13q7d7KeI@latitude>
Date:   Tue, 17 May 2022 15:30:35 +0200
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Marvin Lin <milkfafa@...il.com>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, kwliu@...oton.com,
        tmaimon77@...il.com, avifishman70@...il.com,
        openbmc@...ts.ozlabs.org, tali.perry1@...il.com, kflin@...oton.com
Subject: Re: [PATCH v2 5/5] drivers: media: platform: Add NPCM Video
 Capture/Encode Engine driver

Hello,

first of all, thank you for bringing this driver upstream.

On Fri, May 13, 2022 at 11:34:50AM +0800, Marvin Lin wrote:
> Add driver for Video Capture/Differentiation Engine (VCD) and Encoding
> Compression Engine (ECE) present on Nuvoton NPCM SoCs.
> 
> Signed-off-by: Marvin Lin <kflin@...oton.com>
> ---
>  drivers/media/platform/Kconfig              |    1 +
>  drivers/media/platform/Makefile             |    1 +
>  drivers/media/platform/nuvoton/Kconfig      |   12 +
>  drivers/media/platform/nuvoton/Makefile     |    2 +
>  drivers/media/platform/nuvoton/npcm-video.c | 2074 +++++++++++++++++++

Similar to what I said in reply to the bindings patch, I would prefer to
have the VCD code and the ECE code in two separate files, if possible,
to make reuse of the VCD code alone (on WPCM450) easier.


Best regards,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)