[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <99ed8d4e-8139-851f-47ff-7968822713da@gmail.com>
Date: Tue, 17 May 2022 15:34:51 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
nfraprado@...labora.com, rex-bc.chen@...iatek.com,
zhiyong.tao@...iatek.com
Subject: Re: [PATCH v4 0/5] MediaTek PMIC Wrap improvements and cleanups
On 17/05/2022 12:47, AngeloGioacchino Del Regno wrote:
> This series is meant to improve the mtk-pmic-wrap driver;
> that's done by removing the custom pwrap_wait_for_state() function
> and correctly using the readx_poll_timeout macro instead, which is
> doing exactly the same as the former.
>
> As also shown in a patch [1] by Zhiyong Tao (MediaTek), performing
> a tight loop is not desired: because of the operation timing in the
> SPMI PMICs on these platforms, it makes more sense to wait for some
> microseconds before trying to read again, reducing CPU busy time
> around these state waits. For this purpose, a ~10uS delay was chosen.
>
> While at it, I also took the occasion to tidy up this driver a
> little by optimizing its probe() function.
>
> [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220329115824.13005-2-zhiyong.tao@mediatek.com/
>
> Changes in v4:
> - Avoided moving call to platform_get_irq in patch 3/5
> - Dropped Nicolas' tags from patch 3/5 as it's different now
> - Added newline for readability in comment on patch 5/5
>
Whole series applied, thanks!
Matthias
> Changes in v3:
> - Added two more cleanup patches (4/5, 5/5)
>
> Changes in v2:
> - Fixed a critical typo in patch 1/5. Thanks Nicolas!
>
> AngeloGioacchino Del Regno (5):
> soc: mediatek: pwrap: Use readx_poll_timeout() instead of custom
> function
> soc: mediatek: pwrap: Switch to
> devm_platform_ioremap_resource_byname()
> soc: mediatek: pwrap: Check return value of platform_get_irq()
> soc: mediatek: pwrap: Move IO pointers to new structure
> soc: mediatek: pwrap: Compress of_device_id entries to one line
>
> drivers/soc/mediatek/mtk-pmic-wrap.c | 225 ++++++++++++---------------
> 1 file changed, 97 insertions(+), 128 deletions(-)
>
Powered by blists - more mailing lists